-
Notifications
You must be signed in to change notification settings - Fork 84
Add documentation for the skipPreflightChecks
field in VirtualMachineImport
#805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ineImport` Related to: harvester/harvester#7774 Signed-off-by: Volker Theile <[email protected]>
ibrokethecloud
approved these changes
Jun 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done. Sorry for the delay.
Comment on lines
+148
to
+151
Before the import process starts, the configuration will be verified. If any configuration errors are detected, such as unknown storage class or networks, the import process is aborted. | ||
These preflight checks can be skipped with the `skipPreflightChecks` field. | ||
|
||
The import process can take a while based on the size of the virtual machine, but users should see `VirtualMachineImages` created for each disk in the defined virtual machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Before the import process starts, the configuration will be verified. If any configuration errors are detected, such as unknown storage class or networks, the import process is aborted. | |
These preflight checks can be skipped with the `skipPreflightChecks` field. | |
The import process can take a while based on the size of the virtual machine, but users should see `VirtualMachineImages` created for each disk in the defined virtual machine. | |
The controller checks the configuration before starting the import process, and cancels the import when it detects errors such as unknown StorageClasses or networks. These checks are enabled by default, but can be disabled by setting `skipPreflightChecks` to `true`. | |
The duration of the import process depends on the size of the virtual machine. While the import process may take some time, you should see `VirtualMachineImages` created for each disk in the defined virtual machine. |
votdev
added a commit
to votdev/harvester-docs
that referenced
this pull request
Jul 16, 2025
…tualMachineImport` (harvester#805)" This reverts commit 73affce. Signed-off-by: Volker Theile <[email protected]>
I'm sorry, i merged the PR before i saw the requested changes. The PR #821 will revert this commit. |
votdev
added a commit
that referenced
this pull request
Jul 16, 2025
…tualMachineImport` (#805)" (#821) This reverts commit 73affce. Signed-off-by: Volker Theile <[email protected]>
votdev
added a commit
to votdev/harvester-docs
that referenced
this pull request
Jul 16, 2025
…ineImport` Related to: harvester/harvester#7774 Replaces: harvester#805 Signed-off-by: Volker Theile <[email protected]>
votdev
added a commit
that referenced
this pull request
Jul 16, 2025
…ineImport` (#823) Related to: harvester/harvester#7774 Replaces: #805 Signed-off-by: Volker Theile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
harvester/harvester#7774