Skip to content

Add documentation for the skipPreflightChecks field in VirtualMachineImport #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

votdev
Copy link
Member

@votdev votdev commented Jun 26, 2025

Related Issue(s):

harvester/harvester#7774

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done. Sorry for the delay.

Comment on lines +148 to +151
Before the import process starts, the configuration will be verified. If any configuration errors are detected, such as unknown storage class or networks, the import process is aborted.
These preflight checks can be skipped with the `skipPreflightChecks` field.

The import process can take a while based on the size of the virtual machine, but users should see `VirtualMachineImages` created for each disk in the defined virtual machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before the import process starts, the configuration will be verified. If any configuration errors are detected, such as unknown storage class or networks, the import process is aborted.
These preflight checks can be skipped with the `skipPreflightChecks` field.
The import process can take a while based on the size of the virtual machine, but users should see `VirtualMachineImages` created for each disk in the defined virtual machine.
The controller checks the configuration before starting the import process, and cancels the import when it detects errors such as unknown StorageClasses or networks. These checks are enabled by default, but can be disabled by setting `skipPreflightChecks` to `true`.
The duration of the import process depends on the size of the virtual machine. While the import process may take some time, you should see `VirtualMachineImages` created for each disk in the defined virtual machine.

@votdev votdev merged commit 73affce into harvester:main Jul 16, 2025
4 of 5 checks passed
@votdev votdev deleted the issue_7774_skippreflightchecks branch July 16, 2025 07:38
votdev added a commit to votdev/harvester-docs that referenced this pull request Jul 16, 2025
…tualMachineImport` (harvester#805)"

This reverts commit 73affce.

Signed-off-by: Volker Theile <[email protected]>
@votdev
Copy link
Member Author

votdev commented Jul 16, 2025

I'm sorry, i merged the PR before i saw the requested changes. The PR #821 will revert this commit.

votdev added a commit that referenced this pull request Jul 16, 2025
…tualMachineImport` (#805)" (#821)

This reverts commit 73affce.

Signed-off-by: Volker Theile <[email protected]>
votdev added a commit to votdev/harvester-docs that referenced this pull request Jul 16, 2025
votdev added a commit that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants