Skip to content
This repository was archived by the owner on Mar 2, 2023. It is now read-only.

Empty Stack Modifications#16

Open
imakewebthings wants to merge 2 commits intoharvard-lil:developfrom
imakewebthings:empty
Open

Empty Stack Modifications#16
imakewebthings wants to merge 2 commits intoharvard-lil:developfrom
imakewebthings:empty

Conversation

@imakewebthings
Copy link
Contributor

These modifications should take care of most of the problems outlined in #15. I couldn't produce any console errors, but if somebody would like to provide me with a scenario that will produce them, I'd be happy to tack it on to this pull request. Current changes:

  • Fix the left hand navigation count to say 0 instead of NaN.
  • Add an empty message to the stack instead of the bookends hitting against each other. There is an option added to StackView, emptyMessage, which defaults right now to "No items found." This message is rendered into the empty template found in stackview.templates.js, should anyone need to modify that HTML.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant