This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Dedup fields into generalized search field.#2033
Draft
4ndygu wants to merge 3 commits intoharvard-lil:developfrom
Draft
Dedup fields into generalized search field.#20334ndygu wants to merge 3 commits intoharvard-lil:developfrom
search field.#20334ndygu wants to merge 3 commits intoharvard-lil:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2033 +/- ##
===========================================
- Coverage 62.94% 62.69% -0.25%
===========================================
Files 103 103
Lines 11488 11493 +5
===========================================
- Hits 7231 7206 -25
- Misses 4257 4287 +30
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not ready yet, but this is mostly for visibility's sake.
This PR adds a new
searchfield to the elasticsearch backend that consists of all previously queryable fields, joined into a single space-delimited field. This allows us to cut a lot of nested logic from thesearchparameter and avoid the complexity that deals with search queries that span multiple nested field (e.g. wanting a search that looks for an OR relationship between one opinion, but also another case title).the costs of the current implementation below are:
prepare_%sfunctionsfilter_setvariableattached is a successful test deploy of a query in both the case name and in the case body text.