This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Snippet Removal Part 1— TSV generation to download_storages#1932
Draft
ChefAndy wants to merge 3 commits intoharvard-lil:developfrom
Draft
Snippet Removal Part 1— TSV generation to download_storages#1932ChefAndy wants to merge 3 commits intoharvard-lil:developfrom
ChefAndy wants to merge 3 commits intoharvard-lil:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1932 +/- ##
===========================================
+ Coverage 59.60% 59.62% +0.01%
===========================================
Files 102 103 +1
Lines 10251 10263 +12
===========================================
+ Hits 6110 6119 +9
- Misses 4141 4144 +3
Continue to review full report at Codecov.
|
jcushman
suggested changes
Jul 20, 2021
Contributor
jcushman
left a comment
There was a problem hiding this comment.
Nice start! I think rather than storing these in the base downloads directory, we should store them with each bulk export. You could update scripts.export.init_export to call scripts.update_download_tsv.update_all at the end, with a path of output_path / 'statistics'. And then the about.md links can go to {% url "download-files" "bulk_exports/latest/statistics/..." %}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This part just moves the TSV snippets to regular files. Part 2 with the caching coming up.