Rishit1#38
Open
rishitsaiya wants to merge 21 commits into
Open
Conversation
added detailed documentation for contributions
added registration form
updated stylesheet for registration form
Create q1.txt
added registration form to home page and updated basic structure for practice questions.
added php code to automate Database and tables creation
added .htaccess in 'all testcases' directory issue#32
harshraj22
requested changes
Oct 5, 2019
Owner
There was a problem hiding this comment.
Please follow the guidelines given here and here
develop All development goes on in this branch. If you're making a contribution, you are supposed to make a pull request to develop.
Contributors are expected to create issues and discuss the changes well before opening the pull requests.
If you created your fork a while ago be sure to pull upstream changes into your local repository.
Seems like you merged changes instead of rebasing or checked out from master instead of develop branch. Creating This many commits !!!!
I would prefer pull requests with minimal commits (that too made by contributor related to the issue created ). You might want to have a look here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logo in title, login front end correction