chore: expose webhook url when creating webhook triggers #1303
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose webhook url when creating webhook triggers [Feature]
Today when creating webhook triggers we do not return from the create call the actual webhook that is created. The webhook URL is the most valuable piece of data a user needs when creating a webhook trigger.
By adding this to the response payload we will be able to extract and use it in the Terraform provider.
DEPENDS ON harness/harness-go-sdk#685
Summary:
If I create a webhook trigger, I'm not able to actually use the webhook that is created
Details:
Simply expose the data from the response
Related Issues:
harness/harness-go-sdk#685
Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.
I have used the local version of the SDK and done the dev overrides for the Terraform provider.
I created both webhook and non-webhook triggers and I can successfully create them and use data resources as well to resolve the information necessary.
Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:
PR Check triggers
trigger buildtrigger subcategoryfieldchecktrigger gitleaks