Log actual TcpListener local addresses for clarity#189
Open
DOCtorActoAntohich wants to merge 1 commit intoharlanc:masterfrom
Open
Log actual TcpListener local addresses for clarity#189DOCtorActoAntohich wants to merge 1 commit intoharlanc:masterfrom
TcpListener local addresses for clarity#189DOCtorActoAntohich wants to merge 1 commit intoharlanc:masterfrom
Conversation
if we log ports from config files, we get wrong information...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consider the following minimal config
specifying port 0 means the system will assign any free port. this is cool and all but the logs don't reflect the truth
this is just wrong information because: we can't actually bind to port 0, and we can't have two sockets on one port.
instead, here's the truth:
so as we see, the system properly assigns the ports, but logs don't reflect it.
the fix is simple: instead of printing the info from the config, we can show the actual port the
TcpListenerbinds tothis change can make the app more automation-friendly...
also no reason to parse
SocketAddrfrom string when you know you can use theUNSPECIFIEDaddress, and the port is already given