add STRICT_ARRAY support#183
Merged
harlanc merged 4 commits intoharlanc:masterfrom Mar 7, 2026
Merged
Conversation
Contributor
Author
|
for iOS RTMPHaishinKit compatibility |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds decoding support for the AMF0 STRICT_ARRAY marker in the FLV AMF0 reader so streams containing strict arrays can be parsed without hitting UnknownMarker.
Changes:
- Add
STRICT_ARRAY (0x0A)constant to AMF0 markers. - Route
STRICT_ARRAYmarker to a newread_strict_arraymethod inAmf0Reader. - Implement strict array decoding by reading the array length and then reading each element value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
library/container/flv/src/amf0/amf0_reader.rs |
Adds STRICT_ARRAY handling and implements read_strict_array parsing logic. |
library/container/flv/src/amf0/amf0_markers.rs |
Defines the STRICT_ARRAY marker constant (0x0A). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@harlanc done |
Owner
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.