Skip to content

add STRICT_ARRAY support#183

Merged
harlanc merged 4 commits intoharlanc:masterfrom
nikitos:pr/amf
Mar 7, 2026
Merged

add STRICT_ARRAY support#183
harlanc merged 4 commits intoharlanc:masterfrom
nikitos:pr/amf

Conversation

@nikitos
Copy link
Copy Markdown
Contributor

@nikitos nikitos commented Feb 26, 2026

No description provided.

@nikitos
Copy link
Copy Markdown
Contributor Author

nikitos commented Feb 26, 2026

for iOS RTMPHaishinKit compatibility

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds decoding support for the AMF0 STRICT_ARRAY marker in the FLV AMF0 reader so streams containing strict arrays can be parsed without hitting UnknownMarker.

Changes:

  • Add STRICT_ARRAY (0x0A) constant to AMF0 markers.
  • Route STRICT_ARRAY marker to a new read_strict_array method in Amf0Reader.
  • Implement strict array decoding by reading the array length and then reading each element value.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
library/container/flv/src/amf0/amf0_reader.rs Adds STRICT_ARRAY handling and implements read_strict_array parsing logic.
library/container/flv/src/amf0/amf0_markers.rs Defines the STRICT_ARRAY marker constant (0x0A).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread library/container/flv/src/amf0/amf0_reader.rs Outdated
Comment thread library/container/flv/src/amf0/amf0_reader.rs
Comment thread library/container/flv/src/amf0/amf0_reader.rs
@nikitos
Copy link
Copy Markdown
Contributor Author

nikitos commented Mar 7, 2026

@harlanc done

@harlanc
Copy link
Copy Markdown
Owner

harlanc commented Mar 7, 2026

thanks

@harlanc harlanc merged commit 09c999d into harlanc:master Mar 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants