use config object instead of single val#181
Merged
harlanc merged 1 commit intoharlanc:masterfrom Mar 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors HttpNotifier::new to accept a single HttpNotifierConfig object instead of five individual Option<String> URL parameters. This simplifies the constructor's API and aligns it with the pattern used by other components that accept config structs from the config crate.
Changes:
HttpNotifier::newnow takes aHttpNotifierConfigstruct instead of individual URL fields, and the unusedPublisherInfoimport is removed.- The call site in
service.rsis updated to passhttpnotifier.clone()directly. - The
configcrate is added as a dependency ofstreamhubinCargo.tomlandCargo.lock.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
library/streamhub/src/notify/http.rs |
Refactors HttpNotifier::new to accept HttpNotifierConfig object; removes unused PublisherInfo import |
application/xiu/src/service.rs |
Updates call site to pass httpnotifier.clone() instead of individual fields |
library/streamhub/Cargo.toml |
Adds config crate as a dependency |
Cargo.lock |
Records the new config dependency for streamhub |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks for your contributions!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.