Skip to content

fix: remove --disable-field-trial-config #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+14 −2
Open

fix: remove --disable-field-trial-config #2663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c266068
fix: remove --disable-field-trial-config
pedrowindisch Jun 20, 2024
063e252
Merge branch 'master' into master
kblok Jun 21, 2024
ee5ad83
Merge branch 'master' into master
kblok Jun 21, 2024
021fe43
Merge branch 'master' into master
kblok Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,13 @@
"expectations": ["SKIP"],
"comment": "The test relies on the default page partition key do not contain the source origin. This is not the case for Firefox."
},
{
"testIdPattern": "[cookies.spec] Cookie specs Page.setCookie should set secure same-site cookies from a frame",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome"],
"expectations": ["FAIL"],
"comment": "Failes with fieldtrial testing config in Chrome"
},
{
"testIdPattern": "[coverage.spec] *",
"platforms": ["darwin", "linux", "win32"],
Expand Down Expand Up @@ -1313,6 +1320,12 @@
"expectations": ["FAIL"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
},
{
"testIdPattern": "[cookies.spec] Cookie specs Page.setCookie should set secure same-site cookies from a frame",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome", "chrome-headless-shell"],
"expectations": ["PASS"]
},
{
"testIdPattern": "[cookies.spec] Cookie specs Page.setCookie should set secure same-site cookies from a frame",
"platforms": ["darwin", "linux", "win32"],
Expand Down
3 changes: 1 addition & 2 deletions lib/PuppeteerSharp/ChromeLauncher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ internal static string[] GetDefaultArgs(LaunchOptions options)

var chromiumArguments = new List<string>(
[
"--allow-pre-commit-input",
"--allow-pre-commit-input",
"--disable-background-networking",
"--disable-background-timer-throttling",
"--disable-backgrounding-occluded-windows",
Expand All @@ -74,7 +74,6 @@ internal static string[] GetDefaultArgs(LaunchOptions options)
"--disable-default-apps",
"--disable-dev-shm-usage",
"--disable-extensions",
"--disable-field-trial-config",
"--disable-hang-monitor",
"--disable-infobars",
"--disable-ipc-flooding-protection",
Expand Down