Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
===========================================
- Coverage 100.00% 94.50% -5.50%
===========================================
Files 17 17
Lines 844 855 +11
===========================================
- Hits 844 808 -36
- Misses 0 47 +47 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
I'm confused why the tests are now showing as uncovered |
Collaborator
Author
|
@williamjameshandley rolling back codecov has fixed it 🥲 |
williamjameshandley
previously approved these changes
Feb 20, 2025
Collaborator
williamjameshandley
left a comment
There was a problem hiding this comment.
Many thanks @AdamOrmondroyd
Collaborator
Author
|
you're happy to roll back codecov? |
Collaborator
|
Yes. |
Collaborator
Author
Collaborator
Author
|
Disappointed, but not surprised |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Spotted #6, so have reinstated the tests. Since then, it seems the$3.5\sigma$ contour doesn't plot any more, and the style of the line plots is a bit different. Comparison below:
Old
New
I realised that the "
no_ax" tests should output the same as their "fig, ax = plt.subplots()" counterparts, so they use the same images for comparisonFixes #6
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: