Fix incorrect delta list for bi_grad and bo_grad#63
Merged
Conversation
bi_grad should use delta_i_list[t] and bo_grad should use delta_o_list[t], not delta_f_list[t]. Fixes copy-paste bug in calc_gradient_t()
|
你发过来的邮件怎么都是乱码啊，什么都看不到，再发一次吧。
|
Contributor
Author
|
Hi! I've made the fix directly in this PR — you can review the changes in the 'Files changed' tab above. Please let me know if anything needs to be updated! |
|
你发过来的邮件怎么都是乱码啊，什么都看不到，再发一次吧。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bi_grad should use delta_i_list[t] and bo_grad should use delta_o_list[t], not delta_f_list[t]. Fixes copy-paste bug in calc_gradient_t()