Skip to content

fix: fix the iframe how to join code #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

fix: fix the iframe how to join code #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,18 @@ <h2 class="mt-5">🥳 How to Join </h2>
<p class="lead">Insert the following HTML into your website:</p>
<div class="row">
<div class="col-sm-4 text-center my-5">
<iframe src="/embed.html" width="90px" height="60px" frameborder="0"></iframe>
<iframe style="border:none;" src="/embed.html" width="90px" height="60px"></iframe>
<p class="small text-muted mt-3">Live preview</p>
</div>
<div class="col-sm">
<pre class="px-4 rounded-lg"><code>
&#x3C;iframe src="https://webring.hackclub.com/embed.html" width="90px" height="60px" frameborder="0"&#x3E;&#x3C;iframe&#x3E;
&#x3C;iframe style="border:none;" src="https://webring.hackclub.com/embed.html" width="90px" height="60px"&#x3E;&#x3C;/iframe&#x3E;
</code></pre>
</div>
</div>
<p class="lead">Next, add your name (or nickname!) and URL where you placed the above code snippet at the file
<a rel=”noopener” target="_blank" href="https://github.com/hackclub/webring/edit/main/members.json"><span>Members.json</span></a>.
<a rel=”noopener” target="_blank" href="https://github.com/hackclub/webring/compare">Open a pull request</a> (tutorial
<p class="lead">Next, add your name (or nickname!) and URL where you placed the above code snippet at the file
<a rel=”noopener” target="_blank" href="https://github.com/hackclub/webring/edit/main/members.json"><span>Members.json</span></a>.
<a rel=”noopener” target="_blank" href="https://github.com/hackclub/webring/compare">Open a pull request</a> (tutorial
<a rel=”noopener” target="_blank" href="https://github.com/hackclub/hackclub/blob/main/CONTRIBUTING.md#making-a-pull-request">here</a>
!)and we'll review it within the next 48 hours. Cheers!</p>

Expand Down