[Card Grants] Home page reordering #10674
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
39
to
42
| data-event-sort-organizer-positions-value="<%= @organizer_positions.pluck(:id).to_json %>" | ||
| data-action="sortable:stop->event-sort#sort" | ||
| > | ||
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> |
There was a problem hiding this comment.
Suggested change
| data-event-sort-organizer-positions-value="<%= @organizer_positions.pluck(:id).to_json %>" | |
| data-action="sortable:stop->event-sort#sort" | |
| > | |
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> | |
| data-event-sort-organizer-positions-value="<%= @organizer_positions.pluck(:id).to_json %>" | |
| data-action="sortable:stop->event-sort#sort"> | |
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> |
Comment on lines
39
to
42
| data-sort-card-card-grant-value="<%= current_user.card_grants.activated.pluck(:id).to_json %>" | ||
| data-action="sortable:stop->card-grant#sort" | ||
| > | ||
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> |
There was a problem hiding this comment.
Suggested change
| data-sort-card-card-grant-value="<%= current_user.card_grants.activated.pluck(:id).to_json %>" | |
| data-action="sortable:stop->card-grant#sort" | |
| > | |
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> | |
| data-sort-card-card-grant-value="<%= current_user.card_grants.activated.pluck(:id).to_json %>" | |
| data-action="sortable:stop->card-grant#sort"> | |
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> |
… corresponding data attributes in index.html.erb
Comment on lines
+39
to
42
| data-sort-card-order-value='<%= current_user.card_grants.includes(:stripe_card).map(&:hashid).to_json %>' | ||
| data-action="sortable:stop->sort-card#sort" | ||
| > | ||
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> |
There was a problem hiding this comment.
Suggested change
| data-sort-card-order-value='<%= current_user.card_grants.includes(:stripe_card).map(&:hashid).to_json %>' | |
| data-action="sortable:stop->sort-card#sort" | |
| > | |
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> | |
| data-sort-card-order-value='<%= current_user.card_grants.includes(:stripe_card).map(&:hashid).to_json %>' | |
| data-action="sortable:stop->sort-card#sort"> | |
| <% current_user.card_grants.includes(:stripe_card).activated.each do |grant| %> |
|
Is there an associated issue / feature request / user story behind this PR I can reference for more context? I'm thinking a better way to organize card grants might be just creating a new page for them. |
|
honestly I just came up with this randomly because I felt it's sometimes inconvenient to scroll through all the YSWS grants I was issued |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can reorder organizations on your HCB homepage. This PR extends that functionality by enabling sorting for card grants as well.
Work in progress