Sudo Mode Implementation Exploration #10671
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcornu
force-pushed
the
david/push-rsxovztqnmzr
branch
from
7f4b0f9 to
4784129
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+165
to
+167
| sms: false, | ||
| ).run | ||
|
|
There was a problem hiding this comment.
Suggested change
| sms: false, | |
| ).run | |
| sms: false, | |
| ).run | |
Comment on lines
+114
to
115
| end | ||
| end |
There was a problem hiding this comment.
Suggested change
| end | |
| end | |
| end | |
| end |
Comment on lines
+117
to
118
| end | ||
| end |
There was a problem hiding this comment.
Suggested change
| end | |
| end | |
| end | |
| end |
Comment on lines
+5
to
+8
| <%= form_tag(request.path, method: request.request_method_symbol) do %> | ||
| <% | ||
| Rack::Utils | ||
| .parse_query(request.request_parameters.to_query) |
There was a problem hiding this comment.
Suggested change
| <%= form_tag(request.path, method: request.request_method_symbol) do %> | |
| <% | |
| Rack::Utils | |
| .parse_query(request.request_parameters.to_query) | |
| <%= form_tag(request.path, method: request.request_method_symbol) do %> | |
| Rack::Utils | |
| .parse_query(request.request_parameters.to_query) |
sampoder
reviewed
Jun 21, 2025
| @@ -20,6 +20,7 @@ class UsersController < ApplicationController | |||
| :complete_sms_auth_verification, | |||
| :start_sms_auth_verification] | |||
| before_action :set_shown_private_feature_previews, only: [:edit, :edit_featurepreviews, :edit_security, :edit_admin] | |||
| before_action :enforce_sudo_mode, only: [:update] | |||
There was a problem hiding this comment.
This is super clean - thank you for implementing it this way
sampoder
reviewed
Jun 21, 2025
There was a problem hiding this comment.
The changes to this model LGTM - only comment is I would have implemented preceding_login instead of inital
sampoder
reviewed
Jun 21, 2025
Comment on lines
+7
to
+8
| Rack::Utils | ||
| .parse_query(request.request_parameters.to_query) |
There was a problem hiding this comment.
I think we could make this a partial that we include in all the forms rendered from the LoginsController and then have some shared logic in LoginsController#complete to handle input from that.
sampoder
reviewed
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proof-of-concept code. See #10653 for details.