[Invoices] Add sorting ability #10651
Open
+81
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR adds invoice sorting functionality to allow users to sort invoices by status, date, sponsor, and amount.
- Updated the invoices index view to render sortable table headers.
- Introduced a new partial (_sort_table_header.html.erb) for reusable sort-header functionality.
- Extended the invoices controller to support dynamic sorting parameters and updated SCSS for sorting button styling.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/views/invoices/index.html.erb | Replaced static headers with sortable header partial rendering. |
| app/views/events/_sort_table_header.html.erb | Added a partial to generate links with sorting logic. |
| app/controllers/invoices_controller.rb | Integrated parameter validation and dynamic sorting into the invoices query. |
| app/assets/stylesheets/components/_buttons.scss | Added new styles for sort buttons, including handling of right-aligned buttons. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces invoice sorting functionality for users, with plans to extend sorting to other parts of the platform soon.
Work in progress