Flipper for card grant popovers #10649
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcornu
reviewed
Jun 18, 2025
| @@ -1,6 +1,6 @@ | |||
| <% title "Home" %> | |||
| <% page_md %> | |||
|
|
|||
| <% @show_card_popovers = Flipper.enabled?(:hcb_code_popovers_2023_06_16, current_user) %> | |||
There was a problem hiding this comment.
- concern (non-blocking): This threw me for a loop until I realized we reference this instance variable in a couple of partials and already have similar lines of code in other places. In general I don't expect templates to be setting instance variables as by convention that's usually done in the controller. There might be an opportunity to make this a bit less surprising by
- Moving the logic that sets
@show_card_popoversinto the appropriate controllers (or to a shared helper if it's the same everywhere) - Using
locals(https://guides.rubyonrails.org/layouts_and_rendering.html#passing-local-variables) to pass@show_card_popoversto partials rather than having partials reference it directly
- Moving the logic that sets
- question: In other cases we've restricted this further by checking
organizer_signed_in?as well (e.g. 624af3f). Do we not need that here?
There was a problem hiding this comment.
@davidcornu long term goal is to replace instance variables in partials with locals. I've started work on this. I agree that it should be set in the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a feature flag to conditionally enable card popovers on the home page
Feature flag implementation:
app/views/static_pages/index.html.erb: Added a line to check if the:hcb_code_popovers_2023_06_16feature flag is enabled for the current user and set@show_card_popoversaccordingly.