[Admin] Filter active teenagers within the last 30 days on the team page #10615
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampoder
reviewed
Jun 13, 2025
| @@ -274,7 +276,11 @@ def team | |||
|
|
|||
| @all_positions = @event.organizer_positions | |||
| .joins(:user) | |||
| @all_positions = @all_positions.where(role: @filter) if @filter | |||
| if @filter == "active_teens" | |||
| @all_positions = @all_positions.select { |op| op.user.teenager? && op.user.active? } # select if user is a teenager and active (stole from the other code ;)) | |||
There was a problem hiding this comment.
I think this will break as select forces the SQL query to run and then does the filtering in memory, on Line 284 though we seem to be adding more to the SQL query
There was a problem hiding this comment.
In my testing, nothing broke. but yah, that doesn't seem good. Any suggestions on how to fix it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
https://hackclub.slack.com/archives/C068U0JMV19/p1749575821982219 + @leowilkin ;)
Describe your changes
Added a filter for admins only to see active teenagers for a specific org on the teams page.