Milestone 4 #93
Open
Milestone 4 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…>. also disabled some eslint rules since they persisted even when I fixd them. they were raising errors for code that wasn't there anymore
|
Hi Min! Can you include your deployment link? |
…o unwrap params.slug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Min Hset Hlaing
Closes #4
Pull Request Summary
Checking off milestone 4.
Deploy Link here
Special Instructions (optional)
The build kept failing in the end due to [one main problrm of ParamCheck<RouteContext... > I tried to solve this but failed to do so within my time limit. It should work as intended with just npm run dev though. So sorry for the inconvenience.
Edit: got it fixed
Pull Request Readiness Checklist
Screenshots/Screencast