🐞 fix(icon): small sizes#952
Draft
wellhub-gsevla wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description 📄
There was a bug on
Iconcomponent causingxxxsmallandxxsmallicon sizes to render with wrong sizes.The bug was caused due to a collision between values and indexes during size resolution.
Boxuses index to value like "0->0", "1->4", "2->8", ... so whenxxxsmall(4) orxxsmall(8) was resolved, the index resolution transformed them to the wrong value.PS: the current implementation relies on
fontSizes.Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
No new tests required.
Checklist: 🔍
Screenshots 📸