Skip to content

🐞 fix(icon): small sizes#952

Draft
wellhub-gsevla wants to merge 1 commit into
masterfrom
fix-icon-sizes
Draft

🐞 fix(icon): small sizes#952
wellhub-gsevla wants to merge 1 commit into
masterfrom
fix-icon-sizes

Conversation

@wellhub-gsevla

Copy link
Copy Markdown
Collaborator

JIRA Issue

Description 📄

There was a bug on Icon component causing xxxsmall and xxsmall icon sizes to render with wrong sizes.

The bug was caused due to a collision between values and indexes during size resolution. Box uses index to value like "0->0", "1->4", "2->8", ... so when xxxsmall(4) or xxsmall(8) was resolved, the index resolution transformed them to the wrong value.

PS: the current implementation relies on fontSizes.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

No new tests required.

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Before After
Captura de Tela 2026-07-15 às 10 41 13 Captura de Tela 2026-07-15 às 10 44 44

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant