fix: TUI targets panel missing entries#24
Merged
haugoug merged 1 commit intogvsoc:mainfrom Mar 15, 2026
Merged
Conversation
1. PytestTestset.enqueue() was not calling count_test() or tui.count_target(), so pytest-based tests never appeared in the TUI targets panel. Now registers each test. 2. Targets panel now shows all targets without cutting off. Only constraint: running panel keeps at least 1 content line. 3. Left and right panels now have equal width (50/50 split instead of 2/3 + 1/3).
germainh512
force-pushed
the
fix/tui-targets-panel
branch
from
3453c32 to
28af872
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some targets don't appear in the TUI targets panel. Two causes:
1. Pytest tests not registered with TUI
PytestTestset.enqueue()was not callingrunner.count_test()ortui.count_target(), so pytest-based tests never appeared in the targets panel. Regular Shell tests call these viaTestCommon.enqueue(), but pytest tests have their own enqueue path that bypassed this.2. Targets panel height cap
The targets panel height was capped at
top_h // 3(~10 targets on a typical 40-row terminal). If you have more targets than that, the extra ones are simply not drawn.Fix
Added
count_test()andtui.count_target()calls inPytestTestset.enqueue()for each discovered test.Increased targets panel cap to
top_h // 2, with a minimum of 4 rows reserved for the running panel.Testing
All 142 tests pass.