Skip to content

fix: preserve user env in settings.json#75

Closed
istarwyh wants to merge 2 commits intoguyskk:mainfrom
istarwyh:fix/preserve-user-env-in-settings
Closed

fix: preserve user env in settings.json#75
istarwyh wants to merge 2 commits intoguyskk:mainfrom
istarwyh:fix/preserve-user-env-in-settings

Conversation

@istarwyh
Copy link
Copy Markdown
Contributor

@istarwyh istarwyh commented Mar 7, 2026

Summary

  • preserve user-defined env entries in ~/.claude/settings.json when ccc runs
  • continue removing provider-specific and Claude/Anthropic-prefixed env values from persisted settings
  • update provider tests to cover the preserved user env behavior

Testing

  • go test ./internal/provider ./internal/config

Related

@guyskk
Copy link
Copy Markdown
Owner

guyskk commented Mar 26, 2026

Closed in favor of #76 which implements a more robust solution: properly distinguishes user env from ccc-managed env, filters user env for settings.json, and only passes base+provider env to subprocess.

@guyskk guyskk closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ccc removes user-defined env field from ~/.claude/settings.json on every run

2 participants