Skip to content

refactor(provider): disable PreToolUse hook configuration#69

Merged
guyskk merged 3 commits intomainfrom
revert-pretooluse-hook
Feb 1, 2026
Merged

refactor(provider): disable PreToolUse hook configuration#69
guyskk merged 3 commits intomainfrom
revert-pretooluse-hook

Conversation

@guyskk
Copy link
Copy Markdown
Owner

@guyskk guyskk commented Feb 1, 2026

Summary

PreToolUse hook is not supported yet by Claude Code. This PR disables the PreToolUse hook configuration and removes all related files.

Changes

  • provider.go: Commented out PreToolUse hook configuration with a note that users should use claude_args --disallowed-tools instead
  • provider_test.go: Removed three PreToolUse hook related tests
  • tests/e2e_pretooluse_hook_test.sh: Deleted e2e test script
  • docs/validate-pretooluse-hook.md: Deleted validation document
  • specs/002-askuserquestion-hook/: Deleted entire spec directory

Testing

All tests pass with race detector enabled.

PreToolUse hook is not supported yet. Users should use claude_args
--disallowed-tools instead. The configuration is commented out with
a note for future reference.
PreToolUse hook is not supported yet, so remove the related tests:
- TestSwitchWithHook_PreToolUseConfiguration
- TestSwitchWithHook_PreToolUseAndStopCoexist
- TestSwitchWithHook_PreToolUseMatcherIsAskUserQuestion
PreToolUse hook is not supported yet. Remove related files:
- tests/e2e_pretooluse_hook_test.sh (e2e test script)
- docs/validate-pretooluse-hook.md (validation doc)
- specs/002-askuserquestion-hook/ (entire spec directory)
@guyskk guyskk merged commit 2d66344 into main Feb 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant