Open
Conversation
Merge changes from base fork master
Sync From Base Fork
Owner
|
Hi @edmondchui, thanks for the PR. Could you maybe add some e2e tests if you want this feature to be merged with the master? And I use Grunt to build so you would need to execute the Thanks and regards, Guy |
Merge change from fork base guylabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a clear button at the end of the search input field to clear the search query upon clicking.
The clear button will only appear when the search query is non-empty.
I don't know which tool you are using the build the JS build version so I just modify the javascript in
srcanddistdirectories.