Show per-visit amounts on the shopping page with W1/W2 labels and tooltips - #38
Closed
guplem wants to merge 1 commit into
Closed
Show per-visit amounts on the shopping page with W1/W2 labels and tooltips#38guplem wants to merge 1 commit into
guplem wants to merge 1 commit into
Conversation
The shopping row already showed the buy amount split per shop visit, but it used the wording "Buy 6 packs now" and "+ 3 packs week 2" with no explanation. Issue #23 asks for a short label per visit ("W1", "W2") and a tooltip that spells the label out in full words. Now each split line reads "Buy 6 packs (W1)" and has a tooltip like "W1 = first shop visit, the day before week 1 starts." "W1" matches the "Week 1" section header in the copied list, so the page and the copy use the same visit names. A single-visit product still shows one plain total. Only the on-screen labels and tooltips change; the per-visit amounts still come from the same planShoppingTrips data as the copied list, so the numbers on the page and in the copy stay equal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
guplem
added
the
waiting-for-human-check
guplem
commented
Jul 22, 2026
guplem
left a comment
guplem
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed by an automated pass. Clean and ready for a human check.
What is done well
- Focused, display-only change. The per-visit split itself already shipped (#25); this adds exactly the missing part from the issue: the short
(W1)/(W2)labels and a full-words tooltip for each. - Amounts are untouched. Both the page and the copied list still derive from
planShoppingTripswith the same rounding, so they stay equal. - Tests updated to match the new wording, plus a new test that checks each line's tooltip message. Good coverage of split vs single-total cases.
Findings
- None blocking. All acceptance criteria met.
- Note: the page label uses
W1while the copied list usesWeek 1section headers. The amounts match (the acceptance criterion), only the label format is shorter on the page, which is what the issue asked for.
Verdict: approved pending human review. CI analyze-and-test gate must be green before merge.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #23
The shopping page already splits a product's buy count per shop visit (shipped by #25 / PR #33). What was missing was clear labeling. This PR adds the short per-visit labels and tooltips the issue asks for.
Buy 6 packs (W1)/Buy 3 packs (W2)(before:Buy 6 packs now/+ 3 packs week 2). Every line starts with "Buy", matching the issue example.W1 = first shop visit, the day before week 1 starts.planShoppingTrips(ADR 0014) with identical rounding, so they still match.Test plan
flutter analyzepassesflutter test test/passes (619 tests)(W1)/(W2)with working tooltips, and match the copied list amounts🤖 Generated with Claude Code