Show a freeze-on-arrival note on the shopping page - #36
Merged
Conversation
The one-trip freezer strategy tags items with TripItem.freezeOnArrival and the copied list adds a " (freeze on arrival)" suffix, but the shopping page itself showed nothing. Users who read the page instead of copying missed the instruction to freeze the item. Derive the flag per ingredient from the planned trips the card already receives (same source the copy output reads), and render a note under the ingredient name when set. The note uses the app freeze visual (snowflake + blue, matching the menu page warning) and the exact "freeze on arrival" wording, so screen and copy stay in sync. Closes #28 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
guplem
added
the
waiting-for-human-check
guplem
commented
Jul 22, 2026
guplem
left a comment
guplem
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed by an automated pass. The change is clean and ready for a human check.
What is done well
- The note reads the same
TripItem.freezeOnArrivalflag as the copied list, so the page and the clipboard can never disagree. No model change was needed. - The new
_freezeOnArrivalgetter matches the existing derived-getter style in the same file, and the snowflake icon + blue color match the freeze indicator used elsewhere. - Good test coverage: three widget tests assert the note shows when marked, hides when unmarked, and (important) hides when only a different ingredient must be frozen.
Findings
- None blocking. All acceptance criteria are met.
- Minor, no change needed: the on-screen text is
freeze on arrivalwhile the copy suffix is(freeze on arrival)with parentheses. This is intentional (a styled icon+text vs an inline suffix); the issue only asks the wording to match, and it does.
Verdict: approved pending human review. CI analyze-and-test gate must be green before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #28
The planner already decides which items must be frozen to last (the one-trip / freezer strategy tags each
TripItemwithfreezeOnArrival). Until now that note showed up only in the copied text, not on the page.plannedTrips; nothing was reading it.Test plan
flutter analyzepassesflutter test test/passes (621 tests)🤖 Generated with Claude Code