Skip to content

Update dotcom-components workflow to use riff-raff action#1632

Merged
AnastasiiaBalenko merged 1 commit intomainfrom
ab/use-actions-riff-raff
Apr 14, 2026
Merged

Update dotcom-components workflow to use riff-raff action#1632
AnastasiiaBalenko merged 1 commit intomainfrom
ab/use-actions-riff-raff

Conversation

@AnastasiiaBalenko
Copy link
Copy Markdown
Contributor

What does this change?

There is a High vulnerability lodash vulnerable to Code Injection via _.template imports key names in development environment introduced by transitive dependency lodash 4.17.21 introduced via @guardian/node-riffraff-artifact 0.3.2

npm package @guardian/node-riffraff-artifact is deprecated and it is recommended to use guardian/actions-riff-raff. So this change aligns with current Guardian guidance and removes the affected dependency chain.
What changed:

  • Replaced the manual riffraff deploy step in dotcom-components workflow with guardian/actions-riff-raff@v4.
  • Removed explicit AWS credential configuration step from this job, since v4 of the action handles role assumption internally.
  • Added pull-requests: write permission required by the action for PR commenting.
  • Removed the riffraff npm script from package.json
  • Removed @guardian/node-riffraff-artifact from package.json devDependencies.
  • Regenerated pnpm-lock.yaml, removing the old transitive tree.

How has this change been tested?

Deployed to CODE env, verified that everything works as expected

How can we measure success?

Have we considered potential risks?

Images

Accessibility

@AnastasiiaBalenko AnastasiiaBalenko added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Apr 14, 2026
@AnastasiiaBalenko AnastasiiaBalenko marked this pull request as ready for review April 14, 2026 13:54
@AnastasiiaBalenko AnastasiiaBalenko requested a review from a team as a code owner April 14, 2026 13:54
Copy link
Copy Markdown
Member

@tomrf1 tomrf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@AnastasiiaBalenko AnastasiiaBalenko merged commit 77bc13c into main Apr 14, 2026
7 checks passed
@AnastasiiaBalenko AnastasiiaBalenko deleted the ab/use-actions-riff-raff branch April 14, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants