exclusions support for header, banner, epic and gutter components#1627
Merged
AnastasiiaBalenko merged 10 commits intomainfrom Apr 14, 2026
Merged
Conversation
tomrf1
reviewed
Apr 13, 2026
| }; | ||
|
|
||
| export const inExclusions = <T extends ExclusionChannel>( | ||
| targeting: TargetingByChannel[T], |
Member
There was a problem hiding this comment.
I'm wondering if this file would be simpler (in particular the types) if we defined the targeting type here as e.g.
interface Targeting {
tagIds?: string[];
sectionId?: string;
contentType?: string;
}
I think only epicRouter.ts would need to change how it calls inExclusions.
What do you think?
Contributor
Author
There was a problem hiding this comment.
Yes, thanks, it really makes the function simpler! Updated
tomrf1
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket link
What does this change?
This PR replaces hardcoded banner section/date suppression with a shared, config-driven exclusions system, and applies the same exclusions behaviour across Banner, Epic, Header, and Gutter Ask.
Main changes:
Behaviour notes
If no exclusions exist for a channel, behavior is unchanged.
Matching is case-insensitive for section and tag IDs.
Empty contentTypes and contentTypes containing both Fronts and Articles matches either type.
How has this change been tested?
How can we measure success?
Have we considered potential risks?
Images
Accessibility