Ensure team colours have sufficient contrast #14998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
from
ab60389 to
636af80
Compare
jamesmockett
commented
Dec 12, 2025
Comment on lines
+152
to
+153
| const backgroundLight = sourcePalette.neutral[97]; | ||
| const backgroundDark = sourcePalette.neutral[10]; |
Contributor
Author
There was a problem hiding this comment.
Ideally we would get these from the palette declarations, but they're only available as custom properties so we would have to fetch the values on the client, preventing us from doing the contrast calculations during the server side render.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
force-pushed
the
jm/football-colour-contrast
branch
from
6ddf57c to
1b12961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Checks team colours to ensure they meet WCAG minimum contrast requirements and adds contrasting colours as appropriate
Why?
Stats are shown using team colours and need to be readable in light and dark mode
Screenshots