Skip to content

Conversation

@oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Dec 4, 2025

What does this change?

  • Extends the functionality of the ScrollableCarousel to incorporate requirements of Product Carousel
  • Adds the Product Carousel

Changes to ScrollableCarousel

  • Showing cards of a defined width at different breakpoints by defining a default width for the cards as well as width from different breakpoints by adding
    • type FixedSlideWidth = { defaultWidth: number; widthFromBreakpoints: { breakpoint: Breakpoint; width: number }[];}
    • This has been achieved with a discriminated union type with two kinds
type Props =
	| {
kind: CarouselKind.VisibleSlides;
...
visibleCarouselSlidesOnMobile: number;
visibleCarouselSlidesOnTablet: number;
} | {
kind: CarouselKind.FixedWidthSlides;
....
fixedSlideWidth: FixedSlideWidth;
}
  • Choosing if to add padding or not. On the fronts padding is needed but for our article designs we do not.

    • isArticle: boolean
  • Adds support for subgrid alignment within the cards by adding a new ScrollableCarousel.SubgridItem

Changes to Product Card

Why?

Screenshots

Screenshot 2025-12-11 at 15 33 15

charleycampbell and others added 8 commits November 28, 2025 10:01
- initial build of the card + a storybook
- trying to ruse the product card buttons which required an override to be added as we want a different label on the button
… the page when wired up

- Additional tweaks so the card is more aligned with the Figma designs
- Added logic when there is no heading to put the product and brand name under the image on seperate lines
- Added logic to handle when the product/brand name is longer than one line and needs to wrap
- Using the ProductCardImage instead of Picture for consistency across these elements but happy to change it back again or discuss further
- Added more storybooks
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

@oliverabrahams oliverabrahams changed the base branch from main to filter/carousel-card December 4, 2025 16:27
@oliverabrahams oliverabrahams changed the base branch from filter/carousel-card to main December 4, 2025 16:27
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Dec 4, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 4, 2025
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Dec 4, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 4, 2025
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Dec 10, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants