-
Notifications
You must be signed in to change notification settings - Fork 30
Enable cinemagraphs on non-immersive feature cards #14933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
domlander
wants to merge
3
commits into
main
Choose a base branch
from
doml/feature-card-cinemagraphs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23cd4af to
6f8d13d
Compare
6f8d13d to
2fe01ac
Compare
2fe01ac to
d051491
Compare
d051491 to
4c28d31
Compare
4c28d31 to
d5ed4db
Compare
251cecd to
fbbcf26
Compare
fbbcf26 to
1118767
Compare
1118767 to
39c0c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Enables the use of cinemagraphs on feature cards.
If non-cinemagraph self-hosted video is used in a feature card, a cinemagraph will be rendered
Why?
We want be able to play video within feature cards.
We are not yet ready to show subtitles on feature cards: they will be placed at the top of the card to avoid clashing with the headline & overlay.
Screenshots
### Feature cards
Screen.Recording.2025-11-27.at.17.23.28.mov
Immersive Feature cards
Screen.Recording.2025-11-27.at.17.24.32.mov