Fix: Move RNAD/NFSP agent creation outside game loop#1
Merged
Conversation
Previously, RNaDAgentWrapper and NFSPAgentWrapper were instantiated inside the `for gi in range(games)` loop, causing model re-initialization on every game. This triggered repeated JAX/Haiku compilation, which is extremely slow on certain CPUs (e.g., GitHub Actions AMD EPYC runners). With 50 games, this meant 100 model loads instead of 2, causing runs that should take minutes to take hours. The fix moves agent creation before the loop so models are loaded once and reused across all games. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
RNaDAgentWrapperandNFSPAgentWrapperwere created inside thefor gi in range(games)loop inpyspiel_runner.py. This caused:On GitHub Actions (AMD EPYC CPUs), JAX compilation is slow, causing runs to take hours instead of minutes.
Solution
Move agent instantiation before the game loop so models are loaded once and reused.
Test plan
🤖 Generated with Claude Code