feat: add task lifecycle diagnostics #120
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "strings" | ||
| "time" | ||
| ) | ||
|
|
||
| type logFilter struct { | ||
| TaskID string | ||
| SessionID string | ||
| Since time.Duration | ||
| Level string | ||
| } | ||
|
|
||
| type logEvent struct { | ||
| Time string `json:"time"` | ||
| Level string `json:"level"` | ||
| Msg string `json:"msg"` | ||
| Event string `json:"event"` | ||
| Phase string `json:"phase"` | ||
| TaskID string `json:"taskId"` | ||
| SessionID string `json:"sessionId"` | ||
| RequestID string `json:"requestId"` | ||
| TraceID string `json:"traceId"` | ||
| AttemptID string `json:"attemptId"` | ||
| AttemptNumber int `json:"attemptNumber"` | ||
| TurnKind string `json:"turnKind"` | ||
| ElapsedMs int64 `json:"elapsedMs"` | ||
| Model string `json:"model"` | ||
| Provider string `json:"provider"` | ||
| PID int `json:"pid"` | ||
| FailureCode string `json:"failureCode"` | ||
| Retryable bool `json:"retryable"` | ||
| PromptPreview string `json:"promptPreview"` | ||
| Cleanup string `json:"cleanup"` | ||
| raw string | ||
| } | ||
|
|
||
| func filterLogLines(lines []string, filter logFilter) []logEvent { | ||
| out := make([]logEvent, 0, len(lines)) | ||
| cutoff := time.Time{} | ||
| if filter.Since > 0 { | ||
| cutoff = time.Now().Add(-filter.Since) | ||
| } | ||
| for _, line := range lines { | ||
| line = strings.TrimSpace(line) | ||
| if line == "" { | ||
| continue | ||
| } | ||
| var event logEvent | ||
| if err := json.Unmarshal([]byte(line), &event); err != nil { | ||
| continue | ||
| } | ||
| event.raw = line | ||
| if filter.TaskID != "" && event.TaskID != filter.TaskID { | ||
| continue | ||
| } | ||
| if filter.SessionID != "" && event.SessionID != filter.SessionID { | ||
| continue | ||
| } | ||
| if !cutoff.IsZero() { | ||
| parsed, err := time.Parse(time.RFC3339Nano, event.Time) | ||
| if err == nil && parsed.Before(cutoff) { | ||
| continue | ||
| } | ||
| } | ||
| if filter.Level != "" && !levelAtLeast(event.Level, filter.Level) { | ||
| continue | ||
| } | ||
| out = append(out, event) | ||
| } | ||
| return out | ||
| } | ||
|
|
||
| func levelAtLeast(got string, want string) bool { | ||
| order := map[string]int{"DEBUG": 0, "INFO": 1, "WARN": 2, "ERROR": 3} | ||
| gotLevel, gotOK := order[strings.ToUpper(got)] | ||
| wantLevel, wantOK := order[strings.ToUpper(want)] | ||
| if !gotOK || !wantOK { | ||
| return false | ||
| } | ||
| return gotLevel >= wantLevel | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
| "time" | ||
| ) | ||
|
|
||
| type colorMode string | ||
|
|
||
| const ( | ||
| colorAuto colorMode = "auto" | ||
| colorAlways colorMode = "always" | ||
| colorNever colorMode = "never" | ||
| ) | ||
|
|
||
| func renderPrettyTimeline(events []logEvent, mode colorMode) string { | ||
| var b strings.Builder | ||
| for _, event := range events { | ||
| label := prettyPhase(event.Phase) | ||
| ts := prettyTime(event.Time) | ||
| line := fmt.Sprintf("%s %-18s", ts, label) | ||
| if event.TaskID != "" && event.Phase == "task_received" { | ||
| line += " task=" + shortID(event.TaskID) | ||
| } | ||
| if event.PID != 0 { | ||
| line += fmt.Sprintf(" pid=%d", event.PID) | ||
| } | ||
| if event.Model != "" { | ||
| line += " model=" + event.Model | ||
| } | ||
| if event.FailureCode != "" { | ||
| line += " " + event.FailureCode | ||
| } | ||
| if event.Retryable { | ||
| line += " retryable" | ||
| } | ||
| if event.ElapsedMs > 0 { | ||
| line += fmt.Sprintf(" elapsed=%.1fs", float64(event.ElapsedMs)/1000) | ||
| } | ||
| if event.PromptPreview != "" { | ||
| line += ` "` + event.PromptPreview + `"` | ||
| } | ||
| if event.Cleanup != "" { | ||
| line += " " + event.Cleanup | ||
| } | ||
| if mode != colorNever { | ||
| line = colorizePrettyLine(line, event.Phase) | ||
| } | ||
|
Comment on lines
+47
to
+49
There was a problem hiding this comment.
Every mode except 🤖 Prompt for AI Agents |
||
| b.WriteString(line) | ||
| b.WriteByte('\n') | ||
| } | ||
| return b.String() | ||
| } | ||
|
|
||
| func prettyTime(raw string) string { | ||
| parsed, err := time.Parse(time.RFC3339Nano, raw) | ||
| if err != nil { | ||
| return "--:--:--" | ||
| } | ||
| return parsed.Format("15:04:05") | ||
| } | ||
|
|
||
| func prettyPhase(phase string) string { | ||
| switch phase { | ||
| case "task_received": | ||
| return "task received" | ||
| case "pi_process_started": | ||
| return "pi started" | ||
| case "prompt_written": | ||
| return "prompt written" | ||
| case "first_event_seen": | ||
| return "first event seen" | ||
| case "first_visible_event_seen": | ||
| return "first visible event" | ||
| case "cleanup_started": | ||
| return "cleanup started" | ||
| case "cleanup_finished": | ||
| return "cleanup finished" | ||
| case "task_completed": | ||
| return "completed" | ||
| case "task_failed": | ||
| return "failed" | ||
| case "timed_out", "task_timed_out": | ||
| return "timed out" | ||
| default: | ||
| return strings.ReplaceAll(phase, "_", " ") | ||
| } | ||
| } | ||
|
|
||
| func shortID(id string) string { | ||
| if len(id) <= 8 { | ||
| return id | ||
| } | ||
| return id[:8] | ||
| } | ||
|
|
||
| func colorizePrettyLine(line string, phase string) string { | ||
| switch phase { | ||
| case "task_completed", "cleanup_finished": | ||
| return "\x1b[32m" + line + "\x1b[0m" | ||
| case "task_failed", "task_timed_out", "timed_out", "task_lost": | ||
| return "\x1b[31m" + line + "\x1b[0m" | ||
| case "waiting_input", "retry_scheduled": | ||
| return "\x1b[33m" + line + "\x1b[0m" | ||
| case "pi_process_started", "prompt_written", "first_event_seen", "first_visible_event_seen": | ||
| return "\x1b[36m" + line + "\x1b[0m" | ||
| default: | ||
| return line | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep color flags from changing the command mode.
hasStructuredMode()treats--colorand--no-coloras selectors for structured rendering, sogsd-cloud logs --no-colorstops tailing the raw file and switches to a one-shot pretty snapshot. These flags should only modify pretty output once structured mode is already selected, or validation should require--pretty.🤖 Prompt for AI Agents