ViewMode: Add support for viewing link addresses#2798
Open
guanglinn wants to merge 3 commits intogsantner:masterfrom
Open
ViewMode: Add support for viewing link addresses#2798guanglinn wants to merge 3 commits intogsantner:masterfrom
guanglinn wants to merge 3 commits intogsantner:masterfrom
Conversation
…ode in list items, table cells. Closes gsantner#2800
harshad1
reviewed
Apr 17, 2026
| // For copying link address to clipboard in view-mode | ||
| // For showing and copying link address in view-mode | ||
| _webView.setOnLongClickListener(v -> { | ||
| WebView.HitTestResult hitResult = _webView.getHitTestResult(); |
Collaborator
There was a problem hiding this comment.
IMO if something can be made final then it should be final
Liberal use of final makes the code easier to read imo
Contributor
Author
There was a problem hiding this comment.
Yes, I think so too. Not only security, final can also improve program performance in most cases
Owner
There was a problem hiding this comment.
I see final mostly as note to developer that the value won't change after first assignment (with little exception it being mandatory for passing certain variables to lambda etc).
As far I know and also searched a bit, adding final modifier not generally affects performance
harshad1
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most people just want to view the link address behind the link text instead of directly copying it. This feature supports long pressing the link text to view the link address and copy it.
Related discussion: #1788
Screen recording
SVID_20260414_151529_1.mp4