Support --features protoc-gen-rust-grpc everywhere for protoc#2688
Open
ejona86 wants to merge 2 commits into
Open
Support --features protoc-gen-rust-grpc everywhere for protoc#2688ejona86 wants to merge 2 commits into
ejona86 wants to merge 2 commits into
Conversation
grpc-protobuf-build had disabled the implicit feature by having a feature with dep:protoc-gen-rust-grpc, so I changed build-plugin to act as an alias and enable the now-implicit feature protoc-gen-rust-grpc. Since interop/, grpc-protobuf-build/, and examples/ all use the protoc-gen-rust-grpc feature, you can now build everything at the top-level with just `cargo build --features protoc-gen-rust-grpc` without protoc on the PATH. interop/ is nice in that enabling the protoc-gen-rust-grpc feature cascades to enable the feature on grpc-protobuf-build. Without that, doing `cargo build -p interop --features protoc-gen-rust-grpc` would still require protoc in the PATH. Note that examples doesn't have that, so `GRPC_RUST_REGENERATE_PROTO=1 cargo build -p examples --features protoc-gen-rust-grpc` requires protoc in PATH for the grpc codegen; it still requires --features grpc-protobuf-build/protoc-gen-rust-grpc. Since it is an example, keeping them separate seems the most straight-forward for users, at least for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc-protobuf-build had disabled the implicit feature by having a feature with dep:protoc-gen-rust-grpc, so I changed build-plugin to act as an alias and enable the now-implicit feature protoc-gen-rust-grpc.
Since interop/, grpc-protobuf-build/, and examples/ all use the protoc-gen-rust-grpc feature, you can now build everything at the top-level with just
cargo build --features protoc-gen-rust-grpcwithout protoc on the PATH.interop/ is nice in that enabling the protoc-gen-rust-grpc feature cascades to enable the feature on grpc-protobuf-build. Without that, doing
cargo build -p interop --features protoc-gen-rust-grpcwould still require protoc in the PATH. Note that examples doesn't have that, soGRPC_RUST_REGENERATE_PROTO=1 cargo build -p examples --features protoc-gen-rust-grpcrequires protoc in PATH for the grpc codegen; it still requires --features grpc-protobuf-build/protoc-gen-rust-grpc. Since it is an example, keeping them separate seems the most straight-forward for users, at least for now.CC @dfawley