MCS connection scaling interop tests for Java#12651
Merged
Merged
Conversation
ejona86
reviewed
Feb 11, 2026
…ting." This reverts commit 3719011.
Contributor
Author
|
I realized I forgot to push the commits addressing review comments last week. |
ejona86
reviewed
Feb 19, 2026
ejona86
reviewed
Jun 2, 2026
…dropping intermediary commit with debug statements). # Conflicts: # interop-testing/src/main/java/io/grpc/testing/integration/TestServiceServer.java
kannanjgithub
force-pushed
the
mcs-interop-tests
branch
from
809ae0f to
12f35cf
Compare
# Conflicts: # interop-testing/src/main/java/io/grpc/testing/integration/TestServiceImpl.java
…Impl
Refactor `fullDuplexCall` in `TestServiceImpl` to route peer socket address
requests through the `toChunkQueue()` pipeline and the `ResponseDispatcher`.
This replaces the previous approach of manually branching and bypassing
the standard chunk streaming flow.
Specifically:
- Retrieve the peer's socket address on the request-handling thread inside
`toChunkQueue()` to prevent context loss on the background scheduling thread.
- Overload the `Chunk` class constructor to accept a nullable `peerSocketAddress`
while keeping the default constructor for backward compatibility.
- Ensure `Chunk.toResponse()` only populates the response `payload` field if
`length > 0`, preserving the exact wire-format for empty/address-only requests.
- Remove the manual branch on `whetherSendClientSocketAddressInResponse` and its
associated helper method, simplifying `fullDuplexCall`.
kannanjgithub
force-pushed
the
mcs-interop-tests
branch
from
3a232aa to
6a7bf67
Compare
copybara-service Bot
pushed a commit
to grpc/grpc
that referenced
this pull request
Jun 10, 2026
Corresponding changes in (common) Java server for interop test: grpc/grpc-java#12651 Closes #41664 COPYBARA_INTEGRATE_REVIEW=#41664 from kannanjgithub:mcs 64293f6 PiperOrigin-RevId: 930078263
ejona86
reviewed
Jun 24, 2026
ejona86
approved these changes
Jun 24, 2026
| } | ||
| } | ||
|
|
||
| public void testMcs(TestServiceGrpc.TestServiceStub asyncStub) throws Exception { |
Member
There was a problem hiding this comment.
You don't need a stub passed in. Use asyncStub that has already been created (like the other tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.