Updated BrowserController so can now render in landscape#111
Open
jklp wants to merge 1 commit intogrp:masterfrom
Open
Updated BrowserController so can now render in landscape#111jklp wants to merge 1 commit intogrp:masterfrom
jklp wants to merge 1 commit intogrp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've just made a very small change so when the BrowserController is displayed on iPhone, it can now also be rendered in landscape.
I also tried to get the rest of the app to support landscape and it all seems to work, except when rendering the SubmissionTableCell (the text would stretch / compress when switching between landscape and portrait), so I've left it for now and just made the BrowserController support landscape.