cleanup

[grosser]

I though #1008 was green and I just wanted to rename a few things ... but turns out the test is broken 🤦

rspec ./spec/integration_spec.rb:348
hello world && rspec spec/xxx_spec.rb

instead of echo + run rspec

@andr3i-f I think we need to remove the shellsplit if we want the a && b <files> usecase to work, that is why you added the feature right ?

[grosser]

["sh", "-c", (options[:execute_args] + file_list).join(" ")] that works, but it will be weird if anyone has an argument with spaces or does echo "a && b" 😞

[grosser]

I updated the spec to work now, we can include the example in the readme or docs since it's not very obvious, but afaik kinda the cleanest approach because otherwise we have to join with " " which gets ugly fast :/

[grosser]

I'm pretty happy with the current state, lmk if you see anything wrong and if not I'll release it in a day or so

[andr3i-f]

Sounds good 😄 , I will take a look at it later today. Thanks for your help!

[andr3i-f]

Thanks for catching that failing test, as I just ran the whole spec to see if there were any failures. But I think it looks good! Maybe we should add an example in the readme/cli to run multiple commands with sh -c since that was a bit tricky (for me atleast) to figure out?

[grosser]

5.3.0