Skip to content

GitHub Workflows and Moodle code style fixes#5

Merged
matasarei merged 1 commit intomasterfrom
github-workflows
Aug 7, 2025
Merged

GitHub Workflows and Moodle code style fixes#5
matasarei merged 1 commit intomasterfrom
github-workflows

Conversation

@matasarei
Copy link
Collaborator

No description provided.

@matasarei matasarei force-pushed the github-workflows branch 30 times, most recently from 8a1db71 to 11bd7f9 Compare August 6, 2025 09:33
@matasarei matasarei requested a review from Copilot August 6, 2025 10:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces GitHub Workflows for continuous integration and release automation. It adds comprehensive CI/CD infrastructure including automated testing, code quality checks, and release management while also updating the codebase to meet Moodle coding standards.

  • Adds Moodle Plugin CI workflow with multi-version testing for PHP 8.1-8.4 and Moodle 4.1-5.0
  • Implements automated release workflow with package creation and GitHub releases
  • Updates entire codebase to comply with Moodle coding standards including proper licensing headers, PHPDoc comments, and variable naming conventions

Reviewed Changes

Copilot reviewed 31 out of 32 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
.github/workflows/ci.yml Comprehensive CI pipeline with Moodle Plugin CI, code standards checking, and functional testing
.github/workflows/release.yml Automated release process with version validation, package creation, and GitHub release publishing
classes/**/*.php Updated all PHP classes with proper Moodle licensing headers, PHPDoc documentation, and coding standards compliance
lang/en/local_cleanup.php Reorganized language strings alphabetically and added proper file header
version.php Added comprehensive plugin metadata and documentation
CHANGELOG.md Added comprehensive project changelog with version history
README.md Added CI/CD status badges
Comments suppressed due to low confidence (3)

classes/task/scan.php:54

  • The property name 'data_root' uses underscores but should follow camelCase naming convention. It should be renamed to 'dataroot' to match Moodle coding standards and the existing property declaration on line 44.
        $this->data_root = $CFG->dataroot;

classes/task/cleanup.php:73

  • The property name 'isautoremoveenabled' should be separated with camelCase. It should be renamed to 'isAutoRemoveEnabled' for better readability and consistency with similar boolean property naming patterns.
    private $isautoremoveenabled;

classes/task/cleanup.php:126

  • The property 'dataRoot' is being assigned but the actual property is named 'dataroot' (line 66). This will cause an undefined property error. The assignment should be '$this->dataroot = $CFG->dataroot;'.
        $this->dataRoot = $CFG->dataroot;

@matasarei matasarei force-pushed the github-workflows branch 5 times, most recently from 7e90468 to eddf259 Compare August 7, 2025 12:03
@matasarei matasarei changed the title GitHub Workflows GitHub Workflows and Moodle code style Aug 7, 2025
@matasarei matasarei changed the title GitHub Workflows and Moodle code style GitHub Workflows and Moodle code style fixes Aug 7, 2025
@matasarei matasarei merged commit 1019a62 into master Aug 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant