feat: respect XDG_DATA_HOME and CLAUDE_CONFIG_DIR for path resolution#217
Open
troian wants to merge 1 commit intogriffinmartin:mainfrom
Open
feat: respect XDG_DATA_HOME and CLAUDE_CONFIG_DIR for path resolution#217troian wants to merge 1 commit intogriffinmartin:mainfrom
troian wants to merge 1 commit intogriffinmartin:mainfrom
Conversation
The plugin hardcoded ~/.local/share/opencode/ and ~/.claude/ for all file paths, ignoring XDG_DATA_HOME and CLAUDE_CONFIG_DIR. This prevented running multiple OpenCode instances in parallel with different Claude accounts, since all instances shared the same claude-account-source.txt. Changes: - credentials.ts: getAccountStateFile() and getAuthJsonPaths() use $XDG_DATA_HOME with fallback to ~/.local/share - keychain.ts: readCredentialsFile() and writeBackCredentials() use $CLAUDE_CONFIG_DIR with fallback to ~/.claude - logger.ts: getDefaultLogPath() uses $XDG_DATA_HOME with fallback to ~/.local/share - Tests added for all new paths; existing tests updated to isolate env vars that now affect path resolution - README updated with env var docs and parallel instance usage When unset, behavior is unchanged (same defaults as before). Signed-off-by: Artur Troian <troian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin hardcoded ~/.local/share/opencode/ and ~/.claude/ for all file paths, ignoring XDG_DATA_HOME and CLAUDE_CONFIG_DIR. This prevented running multiple OpenCode instances in parallel with different Claude accounts, since all instances shared the same claude-account-source.txt. Changes:
When unset, behavior is unchanged (same defaults as before).
Summary
Related issue
Testing
Checklist
feat:,fix:,docs:,chore:, etc.)make allpasses locally (runs lint, build, and test)