Skip to content

Conversation

@flomillot
Copy link
Contributor

@flomillot flomillot commented Dec 1, 2025

  • Replace input by MUI Select/OutlinedInput component
  • Add proper label support with InputLabel
  • Adapt the click handlers
  • Add event propagation control for chip interactions
  • Update OverflowableChip and OverflowableChipWithHelperText with boxSx prop
  • Prevent tooltip click propagation in OverflowableText
  • Update demo with DirectoryItemsInput example
  • Some UI fine-tuning

- Replace input by MUI Select/OutlinedInput component
- Add proper label support with InputLabel
- Implement chip-based multi-selection with click handlers
- Add event propagation control for chip interactions
- Update OverflowableChip and OverflowableChipWithHelperText with boxSx prop
- Prevent tooltip click propagation in OverflowableText
- Update demo with DirectoryItemsInput example

Signed-off-by: Florent MILLOT <[email protected]>
}
{...otherProps}
/>
<Box padding="3px" sx={{ cursor: 'default', ...boxSx }} onClick={(e) => e.stopPropagation()}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood well the point of all this is to have the unclickable aura around all the chips ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I comment this part?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the code is clear.
This is the intent that is a bit strange for me (3 pixels unclickable around a clickable Chip inside a clickable Select...)
But I can see that this is in the jira ticket.

Mathieu-Deharbe

This comment was marked as resolved.

Co-authored-by: Mathieu Deharbe <[email protected]>
@flomillot
Copy link
Contributor Author

Code ok, test ok. Just a few questions/remarks and a minor visual problem here, Filtre is cut :

image And I don't think that you have to do it but just in case : the parameters are the only have who don't have any label over them. I don't know if this is intentional. : image

I will try to fix the first comment but for the second one I think it's original behavior

@flomillot
Copy link
Contributor Author

Code ok, test ok. Just a few questions/remarks and a minor visual problem here, Filtre is cut :

image And I don't think that you have to do it but just in case : the parameters are the only have who don't have any label over them. I don't know if this is intentional. : image

First issue fixed here http://github.com/gridsuite/gridstudy-app/pull/3542

Copy link
Contributor

@EtienneLt EtienneLt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Ok code Ok

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

@flomillot flomillot merged commit 4f5b640 into main Dec 5, 2025
5 checks passed
@flomillot flomillot deleted the refactor-directory-items-input branch December 5, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants