-
Notifications
You must be signed in to change notification settings - Fork 4
Refactor DirectoryItemsInput to use MUI Select with improved UX #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace input by MUI Select/OutlinedInput component - Add proper label support with InputLabel - Implement chip-based multi-selection with click handlers - Add event propagation control for chip interactions - Update OverflowableChip and OverflowableChipWithHelperText with boxSx prop - Prevent tooltip click propagation in OverflowableText - Update demo with DirectoryItemsInput example Signed-off-by: Florent MILLOT <[email protected]>
| } | ||
| {...otherProps} | ||
| /> | ||
| <Box padding="3px" sx={{ cursor: 'default', ...boxSx }} onClick={(e) => e.stopPropagation()}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood well the point of all this is to have the unclickable aura around all the chips ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes exactly !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I comment this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the code is clear.
This is the intent that is a bit strange for me (3 pixels unclickable around a clickable Chip inside a clickable Select...)
But I can see that this is in the jira ticket.
Co-authored-by: Mathieu Deharbe <[email protected]>
First issue fixed here http://github.com/gridsuite/gridstudy-app/pull/3542 |
EtienneLt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Ok code Ok
|







Uh oh!
There was an error while loading. Please reload this page.