Add auto-accept PING permission for applications#449
Merged
Conversation
Grant an always-accept PING permission when a NIP-46 connection is established, mirroring the existing GET_PUBLIC_KEY default so ping requests no longer prompt the user. https://claude.ai/code/session_013V6QVcdGxZVQTmwMP4Vqmi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatically grant applications the PING permission with an "always accept" policy when they first connect via NIP-46. This ensures applications can perform keep-alive pings without requiring user approval each time.
Changes
BunkerRequestUtils.ktto check if an application already has a PING permissionApplicationPermissionsEntityfor the PING signer type with:rememberTypeset toALWAYS(auto-accept)acceptUntilset toLong.MAX_VALUE / 1000(effectively no expiration)Implementation Details
The permission is added during the application connection flow in
BunkerRequestUtils, following the same pattern as other auto-granted permissions. The PING permission will be silently accepted for all future requests from that application without user interaction, consistent with the permission system's auto-accept mechanism described in the architecture.https://claude.ai/code/session_013V6QVcdGxZVQTmwMP4Vqmi