Avoid infinite loop if daemon is not responding. #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiofaustino
force-pushed
the
fix-stop-loop
branch
from
40b69ca to
b1b87bd
Compare
caiofaustino
force-pushed
the
fix-stop-loop
branch
from
b1b87bd to
a64cf6c
Compare
Author
|
Issue 2 is being addressed in #108 |
Author
|
@udiWertheimer start here plz =P |
Contributor
udiWertheimer
left a comment
udiWertheimer
left a comment
There was a problem hiding this comment.
Tested ACK 932175e
Nice work, thanks!
Collaborator
|
nit: in the stop case, status label is updated to "STOPPED" but switch is still ON, is it right? |
Author
|
Not right per say, but if I toggle the switch to OFF it triggers the logic to tell the daemon to stop again. I thought best to have this and #108 fixed before changing the logic in the MainActivity. |
Collaborator
|
ack 932175e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some tests I found 2 sources of issues.
1 - If the daemon stops and after that the RPC gets a stop command, it enters an infinite loop of calling stop
@greenaddress do you know why this loop was introduced? Is it really necessary?
2 - getNetworkInfo() might get stuck, causing the Service also get stuck and to not respond to new requests. I still need to investigate this one better so I just added a TODO for now.