Conversation
CoverageTotal line coverage: 86.44% (58946/68195 lines hit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$AGENT_HOME/out/workspace-test-cleanup.Scope
scripts/dev/workspace-test-stale-audit.shwith deterministic full-workspace scanning and normalized schema output (id,crate,path,symbol_or_test,signal,proposed_action,confidence).helper-callgraph.tsvandhelper-orphans.tsvwith deterministic IDs andmanual-reviewflags for macro/reflection edge patterns.decision-rubric.mdandcontract-allowlist.tsvwith explicitremove|keep|rewrite|deferrules and contract/parity/json/exit-code protections.crate-tiers.tsv(candidate-tier-task assignment) andexecution-manifest.md(serialized high-overlap crates + lane gating).Testing
bash -n scripts/dev/workspace-test-stale-audit.sh(pass)mkdir -p "$AGENT_HOME/out/workspace-test-cleanup"(pass)bash scripts/dev/workspace-test-stale-audit.sh --format tsv --out "$AGENT_HOME/out/workspace-test-cleanup/stale-tests.tsv"(pass)cp "$AGENT_HOME/out/workspace-test-cleanup/stale-tests.tsv" "$AGENT_HOME/out/workspace-test-cleanup/stale-tests.r1.tsv"(pass)bash scripts/dev/workspace-test-stale-audit.sh --format tsv --out "$AGENT_HOME/out/workspace-test-cleanup/stale-tests.r2.tsv"(pass)diff -u "$AGENT_HOME/out/workspace-test-cleanup/stale-tests.r1.tsv" "$AGENT_HOME/out/workspace-test-cleanup/stale-tests.r2.tsv"(pass)test -s "$AGENT_HOME/out/workspace-test-cleanup/helper-callgraph.tsv"(pass)test -s "$AGENT_HOME/out/workspace-test-cleanup/helper-orphans.tsv"(pass)awk -F '\t' 'NR>1 && $4=="0" {print $1}' "$AGENT_HOME/out/workspace-test-cleanup/helper-callgraph.tsv" | sort > "$AGENT_HOME/out/workspace-test-cleanup/orphans-from-callgraph.ids"(pass)awk -F '\t' 'NR>1 {print $1}' "$AGENT_HOME/out/workspace-test-cleanup/helper-orphans.tsv" | sort > "$AGENT_HOME/out/workspace-test-cleanup/orphans-reported.ids"(pass)diff -u "$AGENT_HOME/out/workspace-test-cleanup/orphans-from-callgraph.ids" "$AGENT_HOME/out/workspace-test-cleanup/orphans-reported.ids"(pass)test -s "$AGENT_HOME/out/workspace-test-cleanup/decision-rubric.md"(pass)test -s "$AGENT_HOME/out/workspace-test-cleanup/contract-allowlist.tsv"(pass)rg -n 'remove|keep|rewrite|defer|contract|parity|exit code|json' "$AGENT_HOME/out/workspace-test-cleanup/decision-rubric.md"(pass)test -s "$AGENT_HOME/out/workspace-test-cleanup/execution-manifest.md"(pass)test -s "$AGENT_HOME/out/workspace-test-cleanup/crate-tiers.tsv"(pass)awk -F '\t' 'NR>1 && ($2=="" || $3=="" || $4=="") {print $0}' "$AGENT_HOME/out/workspace-test-cleanup/crate-tiers.tsv" | wc -l | tr -d ' ' | rg '^0$'(pass)plan-tooling validate --file /Users/terry/Project/graysurf/nils-cli/docs/plans/workspace-obsolete-tests-cleanup-plan.md(pass)./.agents/skills/nils-cli-verify-required-checks/scripts/nils-cli-verify-required-checks.sh(pass)cargo llvm-cov nextest --profile ci --workspace --lcov --output-path target/coverage/lcov.info --fail-under-lines 85(fail: transient SIGKILL during test listing)CARGO_BUILD_JOBS=4 NEXTEST_TEST_THREADS=1 cargo llvm-cov nextest --profile ci --workspace --lcov --output-path target/coverage/lcov.info --fail-under-lines 85(pass)scripts/ci/coverage-summary.sh target/coverage/lcov.info(pass; Total line coverage 86.47%)Issue