[buddy] tbot: Support templating annotations in kubernetes/argo-cd output
#62668
+45
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like it's done for labels (cf #61804) Our use case: We need to set some of the Teleport cluster labels in the Kubernetes secret's annotations (instead of secret labels) because the label's value contains unsupported character (cf https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) For example we store some cluster URLs (e.g. Docker registry URL) but secret's labels cannot contain a `/` in the value. Signed-off-by: Dan Upton <[email protected]>
|
Amplify deployment status
|
boxofrad
changed the title
kubernetes/argo-cd output
github-actions
bot
requested review from
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato and
zmb3
strideynet
approved these changes
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Code looks good to me - thanks for buddying this and thanks to @cyrilgdn for putting the patch together.
tigrato
approved these changes
Jan 8, 2026
public-teleport-github-review-bot
bot
removed request for
hugoShaka,
marcoandredinis,
mmcallister,
r0mant,
timothyb89 and
zmb3
public-teleport-github-review-bot
bot
removed the request for review
from ptgott
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buddy of: #62636 by @cyrilgdn
changelog: MWI: Add support for templating secret annotations in the tbot's
kubernetes/argo-cdservice