Refactor dynamoDB event queries to use proper pagination solution #62659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshi36
commented
Jan 7, 2026
Comment on lines
-158
to
+164
| const eventSize = 50 * 1024 | ||
| const eventSize = 200 * 1024 |
Contributor
Author
There was a problem hiding this comment.
Increased eventSize to trigger the sub-page break logic:
if l.totalSize+len(data) >= events.MaxEventBytesInResponse {I'm not sure if TestSizeBreak was meant to test another logic path, but it didn't trigger the sub-page break before.
kshi36
commented
Jan 7, 2026
Comment on lines
1010
to
+1014
| for _, tt := range tests { | ||
| // add event parquets (in one .parquet file) to mock S3 getter | ||
| payloads, err := auditEventsToParquet(tt.events) | ||
| require.NoError(t, err) | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // add event parquets (in one .parquet file) to mock S3 getter | ||
| payloads, err := auditEventsToParquet(tt.events) | ||
| require.NoError(t, err) |
Contributor
Author
There was a problem hiding this comment.
Added a t.Run call missing from my previous PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58888
This PR replaces the old pagination solution in DynamoDB events that relied on re-scanning the entire page to match a hashed checkpoint. This caused a performance hit from computing hashes to find a match and potential query processing errors if returning an empty
Iterator.The new solution uses the existing
checkpointKey.Iteratorto perform pagination by creating a new checkpoint at the last processed event, which is triggered if the max response size (1 MiB) is reached or the query limit is reached.A follow-up PR will add logic to handle large events (single events > 1 MiB), which uses this refactor. The test mock
mockQueryis included in this PR (to be used to test large event handling), which allows querying arbitrarily large events without using a dedicated DynamoDB instance. Current behavior only allows storing audit events of size <= 400 KiB (viamaxItemSize).changelog: Improved performance of large search queries for DynamoDB event backend