Disable parent-entity-call feature in schema stitching #1423
+4
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable parent-entity-call feature in schema stitching
Summary
This PR disables the parent-entity-call feature introduced in recent versions PR 6117 of the schema stitching library. This change is necessary to maintain backwards compatibility with our existing implementation while we work on a long-term solution to address underlying schema design issues.
Changes
Motivation
Recent updates to the schema stitching library (PRs #6117 and #6092) introduced changes in how the query planner resolves fields across multiple subschemas. While these changes fix a bug, within our enterprise usecase, they create unexpected additional traffic to our subschemas and break existing functionality in our implementation.
Enterprise Impact
As one of the large enterprise users of this library, we have built significant business-critical functionality based on the previous behavior. While we acknowledge we're depending on what was technically a bug in the previous version:
Short-term Solution
This PR provides a temporary solution and demonstrates a way to switch off this feature and revert to the previous behavior, so that we could introduce a new config to turn it off, allowing us to:
Long-term Plan
We are committed to:
Testing
All test cases have passed successfully, except for the intentionally skipped parent-entity-call tests.
Reviewers
@DenisBadurina
Please review to ensure there are no unintended side effects on other features.