chore(indexer-common): bump @graphprotocol/toolshed to 1.2.1-dips.1#1211
Open
RembrandtK wants to merge 2 commits intomain-dipsfrom
Open
chore(indexer-common): bump @graphprotocol/toolshed to 1.2.1-dips.1#1211RembrandtK wants to merge 2 commits intomain-dipsfrom
RembrandtK wants to merge 2 commits intomain-dipsfrom
Conversation
Contributor
Author
|
@Maikol I have not run this locally, I expect this could be a breaking change for RCA interactions. You likely need to combine with changes you have on your branches? |
Picks up the audit-fix-2 RCA ABI surface published from graphprotocol/contracts deployment/testnet-dips/2024-04-28/audit-fix-2: - toolshed 1.2.0-dips.0 -> 1.2.1-dips.1 (adds recurring-collector decoder helpers and conditions field to RCA tuple) - interfaces transitively bumps to 0.7.1-dips.0 (3-arg acceptIndexingAgreement, 11-field RecurringCollectionAgreement) - address-book transitively bumps to 1.2.0 yarn install + yarn prepare verified clean across all three workspace projects.
The new toolshed splits the SignedRCA argument and adds a uint16 conditions field to the RCA tuple: - SubgraphService.acceptIndexingAgreement now takes (allocationId, rca, signature) instead of (allocationId, signedRca). Unpack proposal.signedRca at all three call sites in dips.ts. - RecurringCollectionAgreement gained `conditions`. Add it to the accept-proposals test fixture and to the pending-rca-consumer test ABI tuple + encoded payload so decodeSignedRCA round-trips correctly.
RembrandtK
force-pushed
the
rk/bump-toolshed-dips
branch
from
1ba2b70 to
ac616d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the audit-fix-2 RCA ABI surface published from graphprotocol/contracts deployment/testnet-dips/2024-04-28/audit-fix-2: