Skip to content

feat: Prevent lambda-promtail from recompiling on every plan #17987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mchaffee-anaconda
Copy link

What this PR does / why we need it:

Currently, if you deploy lambda-promtail using the provided Terraform code, every time you run terraform plan, the golang binary will be recompiled and you will never have a clean plan. Ideally, the binary should only be recompiled if the code actually changes compared to the last apply.

If the code was just a single file, we could use a hash of the script as the trigger, but we have too many files to make hashing feasible. Terraform won't let you hash every file in a folder natively, you'd have to add a third-party module or write a script yourself.

So instead, I've added a new variable, lambda_code_version, which if set, will be used as the trigger for determining when the code should be recompiled. I've added an example to the README.

Special notes for your reviewer:

n/a

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@mchaffee-anaconda mchaffee-anaconda requested a review from a team as a code owner June 5, 2025 15:20
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants