Skip to content

Conversation

@AgnesToulet
Copy link
Contributor

@AgnesToulet AgnesToulet commented Nov 18, 2025

SHOULD ONLY BE MERGED AFTER https://github.com/grafana/k6-cloud-testcoordinator/pull/373

What?

This PR adds a new status to mark the end of a test: ExecutionStatusMarkedAsFailed that should be set when execution.test.fail() is called in the test.

Why?

This will allow to return a better status in the Cloud. For now, the associated k6-cloud-testcoordinator PR uses this to return cloudapi.RunStatusAbortedUser (as if the test was interrupted with abort) but we could work with the cloud team next to introduce a new status.

Note, that an alternative to this if we only want to focus on the short-term solution would be to use ExecutionStatusInterrupted instead. Then, we wouldn't need the PR in k6-cloud-testcoordinator to return cloudapi.RunStatusAbortedUser (as it's already the case when ExecutionStatusInterrupted is received).

Checklist

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

Tests availabel here: https://github.com/grafana/k6-cloud-integration-tests/pull/137

Part of https://github.com/grafana/k6-cloud/issues/4022

@AgnesToulet AgnesToulet marked this pull request as ready for review November 18, 2025 10:53
@AgnesToulet AgnesToulet requested a review from a team as a code owner November 18, 2025 10:53
@AgnesToulet AgnesToulet requested review from inancgumus and joanlopez and removed request for a team November 18, 2025 10:53
@AgnesToulet AgnesToulet added this to the v1.5.0 milestone Nov 18, 2025
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing November 18, 2025 11:03 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing November 18, 2025 11:05 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing November 18, 2025 14:53 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing November 18, 2025 14:55 — with GitHub Actions Inactive
inancgumus
inancgumus previously approved these changes Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants